Open
Conversation
As mentioned in Issue ssine#69, here is my PR :) python-pptx will throw a ValueError, if the lazily loaded file extension of an image is not a supported type (e.g. MPO) - ref. parser.py:155 This ValueError does not get caught while processing the shapes which in turn will crash the program . The simple solution is to just add ValueError to the exception tuple where it gets called in the process_shapes function. The other place the function gets called already has a try-except block and simply ignores all exceptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in Issue #69, here is my PR :)